Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnonymousIframe: WPT BroadcastChannel #2 #32346

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 12, 2022

The previous patch:
https://chromium-review.googlesource.com/c/chromium/src/+/3371612/6
checked an AnonymousIframe and an Iframe wasn't sharing the same
partition.

This one test:

  • Two sibling same-origin anonymous iframe share the same partition.
  • Two same-origin nested anonymous iframe share the same partition.
  • Two same-origin anonymous iframe from different popup do not share
    the same partition.

Bug: 1285331,1226469
Change-Id: I7ebc3a5bbb5e1f12d0ceaac9d89c1deb30174a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379159
Reviewed-by: Andrew Williams <awillia@google.com>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#960946}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3379159 branch 8 times, most recently from d348034 to 4f88cea Compare January 19, 2022 14:21
The previous patch:
https://chromium-review.googlesource.com/c/chromium/src/+/3371612/6
checked an AnonymousIframe and an Iframe wasn't sharing the same
partition.

This one test:
- Two sibling same-origin anonymous iframe share the same partition.
- Two same-origin nested anonymous iframe share the same partition.
- Two same-origin anonymous iframe from different popup do not share
  the same partition.

Bug: 1285331,1226469
Change-Id: I7ebc3a5bbb5e1f12d0ceaac9d89c1deb30174a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379159
Reviewed-by: Andrew Williams <awillia@google.com>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#960946}
@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html   OK: 8/10, TIMEOUT: 2/10  
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html Anonymous iframe and normal iframe aren't in the same partition FAIL: 8/10, MISSING: 2/10 assert_unreached: BroadcastChannel shouldn't cross the anonymous/normal border Reached unreachable code
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html Two sibling same-origin anonymous iframes are in the same partition PASS: 8/10, MISSING: 2/10  
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html Nested same-origin anonymous iframe are in the same partition PASS: 8/10, MISSING: 2/10  
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html Two anonymous iframes in different windows do not share the same partition PASS: 8/10, MISSING: 2/10  

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX
Copy link
Contributor

created crbug/1288906. @past can you help admin merge?

@ArthurSonzogni
Copy link
Member

ArthurSonzogni commented Jan 20, 2022

Sorry about this. It seems to be a problem with Firefox. I believe it was a pre-existing problem, because I have an other patch adding new functions to common.js causing this one to fail

I can't do much. So I believe I will make a patch removing one of the test case, disable it for Firefox, or move it to wpt_internal instead.

edit: I will push: https://chromium-review.googlesource.com/c/chromium/src/+/3401863/

@past past merged commit 3da9d04 into master Jan 20, 2022
@past past deleted the chromium-export-cl-3379159 branch January 20, 2022 17:31
@past
Copy link
Member

past commented Jan 20, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants