Refactor the canvas test generation code #33613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
Cwiiis,
domenic,
foolip,
fserb,
jdm,
jgraham,
kenrussell and
zqzhang
|
Would be useful to refactor this into one commit for the script changes and one commit for the generated output files. |
gsnedders
force-pushed
the
simplify-canvas-build
branch
from
3086985 to
aa5c305
Compare
Done! |
This is running `pyupgrade --py36-plus` & `black` until they reached a fixed point.
This unifies the two largely-identical implementations that generate the canvas (<canvas> and OffscreenCanvas) tests, and gets rid of the duplication of templates. This does, unfortunately, mean a small number of tests (~140 of the several thousand generated) have whitespace changes. Hopefully this makes it easier for any future work on these scripts.
This is entirely changes to blank lines (see `git-diff --ignore-blank-lines`), except for 2d.path.roundrect.radius.noargument.html which appears to have never been generated since 31eb342 when the test name was modified.
gsnedders
force-pushed
the
simplify-canvas-build
branch
from
aa5c305 to
ba624cc
Compare
|
Apparently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the two largely-identical implementations that generate the canvas (<canvas> and OffscreenCanvas) tests, and gets rid of the duplication of templates.
This does, unfortunately, mean a small number of tests (~140 of the several thousand generated) have whitespace changes.
Hopefully this makes it easier for any future work on these scripts!