Add popup support for <input>s styled as buttons and text fields #34200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 25, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3656513
branch
from
443bd26
to
1889e37
Compare
With this CL, several <input> element types, in addition to the existing support for <button>, will be able to use the invoking attributes (togglepopup, showpopup, and hidepopup) to invoke a popup. This CL also adds enforcement of the resolution below, so that any button that would otherwise submit a form cannot also/instead trigger a popup. openui/open-ui#409 (comment) Bug: 1307772 Change-Id: I7eb5cd726bcacd26de5085871d7c3077c1f78baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3656513 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1007708}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3656513
branch
from
1889e37
to
7091d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this CL, several <input> element types, in addition to the existing
support for <button>, will be able to use the invoking attributes
(togglepopup, showpopup, and hidepopup) to invoke a popup. This CL
also adds enforcement of the resolution below, so that any button
that would otherwise submit a form cannot also/instead trigger a
popup.
openui/open-ui#409 (comment)
Bug: 1307772
Change-Id: I7eb5cd726bcacd26de5085871d7c3077c1f78baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3656513
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1007708}