Get the elements from queue in block mode #34333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there are cases a worker get no more tests to run and quit early where there are still groups in the queue. This is because poll from Queue in unblock mode is not safe. Now poll in block mode and add a sentinal for each worker at the end of queue.
wpt-pr-bot
added
infra
wptrunner
jgraham
requested changes
Jun 10, 2022
| @@ -383,7 +383,7 @@ def group_metadata(cls, state): | |||
| def group(self): | |||
| if not self.current_group or len(self.current_group) == 0: | |||
| try: | |||
| self.current_group, self.current_metadata = self.test_queue.get(block=False) | |||
| self.current_group, self.current_metadata = self.test_queue.get(block=True) | |||
There was a problem hiding this comment.
I'm quite worried by this blocking forever; it seems to create a lot of potential for a bug to cause a hang. I'm not sure why reading a populated queue without blocking should be failing, but at the least there should be some kind of timeout.
There was a problem hiding this comment.
Hi James, I updated per your suggestion. Can you pls review again? Thanks!
jgraham
reviewed
Jun 14, 2022
jgraham
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there are cases a worker get no more tests to run
and quit early where there are still groups in the queue. This
is because poll from Queue in unblock mode is not safe.
Now poll in block mode and add a sentinal for each worker at
the end of queue.