[webauthn] WPT for autocomplete="webauthn" #34410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 13, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3704319
branch
2 times, most recently
from
41f8ecf to
d82b85f
Compare
Add a web platform test for the "webauthn" autocomplete detail token. Drive-by fix to the "contact category" bit of the test. The test intended to exceed the maximum number of tokens for an autofill field type of category "contact" [1], but used the field name "name" which is of category "normal". Change "name" to "tel" which actually is of category "contact". See whatwg/html#8006 [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill-processing-model Bug: 1171985 Change-Id: Idfdee8447c5eaa6b4d5ab34249dee2c46b82ecec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704319 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1014943}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3704319
branch
from
d82b85f to
ffb29c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a web platform test for the "webauthn" autocomplete detail token.
Drive-by fix to the "contact category" bit of the test. The test
intended to exceed the maximum number of tokens for an autofill field
type of category "contact" [1], but used the field name "name" which
is of category "normal". Change "name" to "tel" which actually is of
category "contact".
See whatwg/html#8006
[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill-processing-model
Bug: 1171985
Change-Id: Idfdee8447c5eaa6b4d5ab34249dee2c46b82ecec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704319
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014943}