Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename togglepopup->popuptoggletarget, etc. #34854

Merged
merged 1 commit into from
Jul 17, 2022

Commits on Jul 17, 2022

  1. Rename togglepopup->popuptoggletarget, etc.

    Per the resolution [1], we are renaming:
     - togglepopup -> popuptoggletarget
     - showpopup   -> popupshowtarget
     - hidepopup   -> popuphidetarget
    
    A subsequent CL will add IDL reflections of these attributes.
    
    [1] openui/open-ui#382 (comment)
    
    Bug: 1307772
    Change-Id: I3cf663b50b0b0f10cbc39d723608b1dcd28662e0
    Cq-Do-Not-Cancel-Tryjobs: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3764624
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Reviewed-by: Joey Arhar <jarhar@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1025053}
    mfreed7 authored and chromium-wpt-export-bot committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    f379021 View commit details
    Browse the repository at this point in the history