Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLHttpRequest test fixes #352

Merged
merged 2 commits into from
Sep 26, 2013
Merged

Conversation

jungkees
Copy link
Contributor

  • abort-event-loadend.htm: changed to call abort() in onloadstart rather than in onreadystatechange; otherwise the test ends up with throwing InvalidStateError in send().
  • getresponseheader-error-state.htm: corrected the URL composition part; without "//", location.protocol ("http:") tends to be interpreted as [protoco] + [host] + [path] by user agent, which leads the result to 404 error instead of CORS failure.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/333

This is an external review system which you may optionally use for the code review of your pull request.

zcorpan added a commit that referenced this pull request Sep 26, 2013
XMLHttpRequest test fixes
@zcorpan zcorpan merged commit 8319348 into web-platform-tests:master Sep 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants