Revert "webauthn: Update abort handling to take an abort reason" #35692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 29, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3861492
branch
from
3857f7b to
65b83b7
Compare
This reverts commit 626cf945c1cb51b2b51cf145d5be7cdaf6e2879b. Reason for revert: crbug.com/1357180 Original change's description: > webauthn: Update abort handling to take an abort reason > > AbortController now has a `reason` [1] parameter which > has been added to Web Authentication [2], Credential Management [3], > and Web OTP [4]. We should update CredentialsContainer to take > this `reason` to the promise then aborting a request. > > [1] https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/reason > [2] w3c/webauthn#1706 > [3] w3c/webappsec-credential-management#196 > [4] WICG/web-otp#57 > > Bug: 1272541, 1329938 > Change-Id: Idb9ef40d6a97ae240ae3a28892a426e4c0ffbfef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715820 > Commit-Queue: Euisang Lim <eui-sang.lim@samsung.com> > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1039866} Bug: 1272541, 1329938, 1357180 Change-Id: Ida573df85179b8575b3cba725109a45a09a30507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3861492 Auto-Submit: Francois Pierre Doray <fdoray@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Owners-Override: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1040433}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3861492
branch
from
65b83b7 to
0d9bf68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 626cf945c1cb51b2b51cf145d5be7cdaf6e2879b.
Reason for revert: crbug.com/1357180
Original change's description:
Bug: 1272541, 1329938, 1357180
Change-Id: Ida573df85179b8575b3cba725109a45a09a30507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3861492
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Owners-Override: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040433}