Combine the popoverhide/popovershow events into one beforetoggle event #37031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 18, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4035832
branch
2 times, most recently
from
9f5066f to
ac1c65f
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4035832
branch
6 times, most recently
from
04ed215 to
4bf0dc6
Compare
See [1] and [2] for context. This eliminates the "popoverhide" and "popovershow" events, and replaces them with the "beforetoggle" event, for both of these transitions. The event is a BeforeToggleEvent, which has attributes `currentState` and `newState`, both of which are either "open" or "closed" (and opposite of each other). [1] openui/open-ui#607 (comment) [2] whatwg/html#8221 (comment) Bug: 1307772 Change-Id: I404861a10579365b56e6e8eae7c29f88a5aac166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035832 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1080695}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4035832
branch
from
4bf0dc6 to
a51313e
Compare
frikke
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1] and [2] for context. This eliminates the "popoverhide" and
"popovershow" events, and replaces them with the "beforetoggle" event,
for both of these transitions. The event is a BeforeToggleEvent,
which has attributes
currentStateandnewState, both of whichare either "open" or "closed" (and opposite of each other).
[1] openui/open-ui#607 (comment)
[2] whatwg/html#8221 (comment)
Bug: 1307772
Change-Id: I404861a10579365b56e6e8eae7c29f88a5aac166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035832
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1080695}