orientation.unlock doesn't return promise

[makotokato]

hidden_document.html uses promise_rejects_dom for orientation.unlock, but it doesn't return promise. So we should use assert_throws_dom instead.

Also, since this test has some issues, this fix includes it

• We don't have screen-orientation/resources/orientation_.js
• Import orientation-utils.js to use getOppositeOrientation
• Typo fix of make_cleanup.

[marcoscaceres]

Thanks for fixing these @makotokato! Not sure how these got through.

[engedy]

Chromium Build Sheriff here, we are wondering if these changes could have resulted in non-deterministic harness errors we are observing with screen-orientation/hidden_document.html, see https://crbug.com/1393567.

@makotokato If you have a bit of time, could you please take a look?

[makotokato]

Chromium Build Sheriff here, we are wondering if these changes could have resulted in non-deterministic harness errors we are observing with screen-orientation/hidden_document.html, see https://crbug.com/1393567.

@makotokato If you have a bit of time, could you please take a look?

This PR is a fix of broken test, and this is for w3c/screen-orientation#232. You should ask @michaelwasserman or WebDriver team for it. (This test uses test_driver.set_window_rect and test_driver.minimize_window).

[engedy]

Thank you, I will follow up with @michaelwasserman