Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update popover post-toggle event naming and behavior #38206

Merged
merged 1 commit into from
Jan 30, 2023

Commits on Jan 30, 2023

  1. Update popover post-toggle event naming and behavior

    This CL updates the post-toggle event in the following ways:
     1. Rename the 'aftertoggle' event to 'toggle'.
     2. Rename PopoverToggleEvent to ToggleEvent.
     3. Rename the currentState attribute to oldState.
     4. Add event coalescing behavior. If two transitions occur before the
        first 'toggle' event has been fired, cancel the first event and
        queue a replacement that has oldState === newState.
    
    These changes were driven by the corresponding changes to the spec PR:
      whatwg/html#8717
    
    Bug: 1307772
    Change-Id: Iabc5a9093d7cef3bbd6e54e488d8e571c51ea568
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195120
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Commit-Queue: Joey Arhar <jarhar@chromium.org>
    Reviewed-by: Joey Arhar <jarhar@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1098728}
    mfreed7 authored and chromium-wpt-export-bot committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    bfc0288 View commit details
    Browse the repository at this point in the history