Cleanup some idlharness tests and make it clearer what they test. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <link rel="author" title="W3C" href="http://www.w3.org/" /> | ||
| <link rel="help" href="http://www.w3.org/TR/page-visibility/#sec-document-interface"/> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/webidl2.js/lib/webidl2.js"></script> | ||
| <script src="/resources/WebIDLParser.js"></script> |
There was a problem hiding this comment.
Seems you prefer WebIDLParser.js to webidl2.js :)
Another, WebIDLParser.js isn't maintained @ https://github.com/w3c/testharness.js or other places in github.
There was a problem hiding this comment.
@zqzhang on w3c-test.org, /resources/WebIDLParser.js is a symlink to /resources/webidl2/lib/webidl2.js. And the wptserve code re-routes /resources/WebIDLParser.js requests to /resources/webidl2/lib/webidl2.js
That said, I'm not clear why for new tests we're not just switching over to /resources/webidl2/lib/webidl2.js There are not even that many existing tests that use /resources/WebIDLParser.js (so even chaning all the existing tests to use /resources/webidl2/lib/webidl2.js would not be a lot of work).
zqzhang
added a commit
that referenced
this pull request
Dec 5, 2013
Cleanup some idlharness tests and make it clearer what they test.
zqzhang
pushed a commit
to zqzhang/web-platform-tests
that referenced
this pull request
Dec 5, 2013
zqzhang
pushed a commit
to zqzhang/web-platform-tests
that referenced
this pull request
Dec 5, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.