Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import html5lib-tests #39305

Closed
wants to merge 1 commit into from
Closed

Import html5lib-tests #39305

wants to merge 1 commit into from

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 31, 2023

Running the script gave this rather concerning output:

Previous HEAD position was 9b4a29c Test </p> and </br> in SVG (#135)
HEAD is now at 1314b09 Correct another <template> test
adoption01
adoption02
blocks
comments01
doctype01
domjs-unsafe
entities01
entities02
foreign-fragment
WARNING: id 74a8a40517c6fe110f0c71af7efb56d459ea8227 seen multiple times in file foreign-fragment this time for test (svg desc, <figure></figure>) before for test ('svg desc', '<figure></figure>'), skipping
html5test-com
inbody01
isindex
main-element
math
menuitem-element
namespace-sensitivity
noscript01
pending-spec-changes-plain-text-unsafe
pending-spec-changes
plain-text-unsafe
ruby
scriptdata01
WARNING: id e04bd4c273176c0638e98dce1cbdcfc6438ec7eb seen multiple times in file scriptdata01 this time for test (None, FOO<script>'<!-->'</script>BAR) before for test (None, "FOO<script>'<!-->'</script>BAR"), skipping
search-element
svg
tables01
template
WARNING: id b4ab56fd9e9cebf479d14adfa523c06d16483a5e seen multiple times in file template this time for test (None, <body><template><template><tr></tr></template><td></td></template>) before for test (None, '<body><template><template><tr></tr></template><td></td></template>'), skipping
WARNING: id d958f7d44faf772d1fb60f1a8f186f837ca735d9 seen multiple times in file template this time for test (None, <body></body><template>) before for test (None, '<body></body><template>'), skipping
tests1
WARNING: id 18b58d1de184b6866963c902ff8451dd3522f540 seen multiple times in file tests1 this time for test (None, <b><table><td><i></table>) before for test (None, '<b><table><td><i></table>'), skipping
WARNING: id daa9d8440e2bc4d560536b52123b01e52aa81692 seen multiple times in file tests1 this time for test (None, <p><hr></p>) before for test (None, '<p><hr></p>'), skipping
tests10
tests11
tests12
tests14
tests15
tests16
tests17
tests18
tests19
WARNING: id 8d45a57b7093df38c88dccb1f3fba6a62c810445 seen multiple times in file tests19 this time for test (None, <!doctype html><select><option></optgroup>) before for test (None, '<!doctype html><select><option></optgroup>'), skipping
WARNING: id 9e4d91f02184de1b1e5d927144bb06d3bc78bb09 seen multiple times in file tests19 this time for test (None, <!doctype html><table><i>a<b>b<div>c<a>d</i>e</b>f) before for test (None, '<!doctype html><table><i>a<b>b<div>c<a>d</i>e</b>f'), skipping
tests2
tests20
WARNING: id aa2a707a627408758a0ee845896ef088d6136013 seen multiple times in file tests20 this time for test (None, <!doctype html><address><button></address>a) before for test (None, '<!doctype html><address><button></address>a'), skipping
tests21
WARNING: id 7cdfc1d2d87a4f9ebd754d18dc7b55f73f5ba58b seen multiple times in file tests21 this time for test (None, <svg><![CDATA[foo) before for test (None, '<svg><![CDATA[foo'), skipping
WARNING: id 30b6ff244d2cd3716c1ad482e30ff294dcfed2b7 seen multiple times in file tests21 this time for test (None, <svg><![CDATA[]] >]]>) before for test (None, '<svg><![CDATA[]] >]]>'), skipping
tests22
tests23
tests24
tests25
tests26
tests3
tests4
tests5
tests6
tests7
tests8
tests9
tests_innerHTML_1
WARNING: id b55e32e22980fe99bab895005a0a757a2fcb1a2b seen multiple times in file tests_innerHTML_1 this time for test (table, <a>) before for test ('table', '<a>'), skipping
WARNING: id f8770f97671a805b37277db7e42536b40c0804cb seen multiple times in file tests_innerHTML_1 this time for test (tbody, <a><td>) before for test ('tbody', '<a><td>'), skipping
WARNING: id f8770f97671a805b37277db7e42536b40c0804cb seen multiple times in file tests_innerHTML_1 this time for test (tbody, <a><td>) before for test ('tbody', '<a><td>'), skipping
WARNING: id dc0e2582ff83e60c0eb549dc3387562d3482e364 seen multiple times in file tests_innerHTML_1 this time for test (tr, <td><table></table><td>) before for test ('tr', '<td><table></table><td>'), skipping
tricky01
webkit01
webkit02
scripted_adoption01
scripted_ark
scripted_webkit01

I guess you would know what that means @gsnedders?

@annevk annevk requested a review from gsnedders March 31, 2023 13:20
@annevk
Copy link
Member Author

annevk commented Mar 31, 2023

Hmm, it looks like there might actually be duplicates in the source material.

@annevk annevk mentioned this pull request Mar 31, 2023
Merged
@gsnedders
Copy link
Member

I guess you would know what that means @gsnedders?

I've no idea.

@annevk
Copy link
Member Author

annevk commented Mar 31, 2023

It seems like it's just duplicates. Once html5lib/html5lib-tests#159 lands I can run it again and the WARNINGs should disappear.

@annevk annevk mentioned this pull request Apr 1, 2023
Open
gsnedders pushed a commit to html5lib/html5lib-tests that referenced this pull request Apr 6, 2023
@annevk @gsnedders
Remove duplicate tests
4e82e3d 
As identified in web-platform-tests/wpt#39305.
@annevk
Copy link
Member Author

annevk commented Apr 11, 2023

Superseded by #39482.

@annevk annevk closed this Apr 11, 2023
@annevk annevk deleted the annevk/import-html5lib-tests branch April 11, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders Awaiting requested review from gsnedders

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@jgraham jgraham

Labels
do not merge yet html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @gsnedders @jgraham @wpt-pr-bot