Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for draggable attribute. #419

Closed
wants to merge 1 commit into from
Closed

Added test for draggable attribute. #419

wants to merge 1 commit into from

Conversation

sunling
Copy link

@sunling sunling commented Nov 9, 2013

Added test for draggable attribute.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/409

This is an external review system which you may optionally use for the code review of your pull request.

@sunling
Copy link
Author

sunling commented Nov 11, 2013

@hoppipolla-critic-bot.I am sorry,I am confused about your comment.what would you like me to do?

@zqzhang
Copy link
Contributor

zqzhang commented Nov 12, 2013

@sunling , hoppipolla critic is just a review system combined to this project. Review comments may be there and should be addressed by you.

So far, @Ms2ger has 2 comments at https://critic.hoppipolla.co.uk/showcomments?review=409&filter=open-issues, which needs your action.

@zqzhang
Copy link
Contributor

zqzhang commented Nov 12, 2013

And please check if your tests are covered by #280, thanks.

@sunling
Copy link
Author

sunling commented Nov 12, 2013

Thanks a lot,if it is covered,How should I do?

@zqzhang
Copy link
Contributor

zqzhang commented Nov 12, 2013

If your tests have been covered, just close this PR :)

@sunling
Copy link
Author

sunling commented Nov 12, 2013

Sorry again,Before I close this PR,Actually I am not sure if this test is covered or not.I have no access to see any code in #280

@sunling
Copy link
Author

sunling commented Nov 12, 2013

Yes,I can.Thanks for your patience!

@sunling
Copy link
Author

sunling commented Nov 12, 2013

@zqzhang I have one more question to bother you,I don't know how to close this PR.

@zqzhang
Copy link
Contributor

zqzhang commented Nov 13, 2013

Under this comment box, there are 2 buttons, one is 'Comment' in green background, the other is 'Close' in light gray background. I think just clicking the 'Close' button is OK.

@sunling sunling closed this Nov 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants