-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for draggable attribute. #419
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/409 This is an external review system which you may optionally use for the code review of your pull request. |
@hoppipolla-critic-bot.I am sorry,I am confused about your comment.what would you like me to do? |
@sunling , hoppipolla critic is just a review system combined to this project. Review comments may be there and should be addressed by you. So far, @Ms2ger has 2 comments at https://critic.hoppipolla.co.uk/showcomments?review=409&filter=open-issues, which needs your action. |
And please check if your tests are covered by #280, thanks. |
Thanks a lot,if it is covered,How should I do? |
If your tests have been covered, just close this PR :) |
Sorry again,Before I close this PR,Actually I am not sure if this test is covered or not.I have no access to see any code in #280 |
Yes,I can.Thanks for your patience! |
@zqzhang I have one more question to bother you,I don't know how to close this PR. |
Under this comment box, there are 2 buttons, one is 'Comment' in green background, the other is 'Close' in light gray background. I think just clicking the 'Close' button is OK. |
Added test for draggable attribute.