[webdriver-bidi] Add tests for browsingContext.locateNodes #42565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
DanielRyanSmith,
foolip,
jgraham,
jrandolf-2,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
whimboo
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Great work @jimevans! So far this looks already pretty good especially with having in mind that you are currently not able to run these tests at all because no browser implemented this API yet! I'm impressed.
I had a look over all the test files and added quite a couple of review comments inline. Please let me know if something is unclear or requires further discussion.
webdriver/tests/bidi/browsing_context/locate_nodes/max_node_count.py
Outdated
Show resolved
Hide resolved
| await_promise=True, | ||
| ) | ||
|
|
||
| parent_node_reference = { "sharedId": script_result["result"]["sharedId"] } |
There was a problem hiding this comment.
Note that the returned value from evaluate is already the result so you can directly re-use it. Maybe rename script_result to node_reference.
There was a problem hiding this comment.
I think I've got this right now? Please double-check my code.
webdriver/tests/bidi/browsing_context/locate_nodes/start_nodes.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Henrik Skupin <mail@hskupin.info>
Co-authored-by: Henrik Skupin <mail@hskupin.info>
Co-authored-by: Henrik Skupin <mail@hskupin.info>
Co-authored-by: Henrik Skupin <mail@hskupin.info>
Co-authored-by: Henrik Skupin <mail@hskupin.info>
Co-authored-by: Henrik Skupin <mail@hskupin.info>
OrKoN
reviewed
Oct 27, 2023
OrKoN
reviewed
Oct 27, 2023
lutien
requested changes
Nov 7, 2023
webdriver/tests/bidi/browsing_context/locate_nodes/start_nodes.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/browsing_context/locate_nodes/start_nodes.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/browsing_context/locate_nodes/ownership.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/browsing_context/locate_nodes/max_node_count.py
Outdated
Show resolved
Hide resolved
lutien
reviewed
Nov 7, 2023
Co-authored-by: Alexandra Borovova <lutien@users.noreply.github.com>
Co-authored-by: Alexandra Borovova <lutien@users.noreply.github.com>
lutien
approved these changes
Nov 7, 2023
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
whimboo
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.