serial: Expose connection state for Bluetooth serial ports #43240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 18, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5039155
branch
2 times, most recently
from
ff772a4 to
dc84767
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5039155
branch
6 times, most recently
from
5ab4954 to
391596b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5039155
branch
2 times, most recently
from
1a31684 to
3ffa189
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5039155
branch
5 times, most recently
from
7abbe26 to
dfd7207
Compare
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1268876}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5039155
branch
from
dfd7207 to
9a81a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant spec change: WICG/serial#197
This CL adds a connected attribute to the SerialPort interface
that exposes the logical connection state of the serial port.
The behavior for Bluetooth serial ports is changed so that the
connect and disconnect events are dispatched when the connection
state of the Bluetooth device changes. The behavior is unchanged
for wired serial ports.
Intent to Prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao
Bug: 1488031
Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1268876}