-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interop Accessibility: add test_driver.get_accessibility_tree #43773
base: master
Are you sure you want to change the base?
Interop Accessibility: add test_driver.get_accessibility_tree #43773
Conversation
This change is a part of the work to find and implement additional ways we can test conformance of browsers with accessibility specs. I think this is a good step in following that goal but I am not sure of all the steps that will need to be done to realize it. Demonstration tests of this can be seen in this downstream change in Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5100655 And I'm posting this work here in part to fulfill a comment in that change. https://chromium-review.googlesource.com/c/chromium/src/+/5100655/comments/2f3aa4b4_da35e7ed |
To land this in testdriver.js and use it from tests in WPT, you'll need to go through https://github.com/web-platform-tests/rfcs. Note that there is an exception for "extending testdriver.js with a method that closely matches a WebDriver endpoint" but this is wrapping a CDP command, not a standardized WebDriver endpoint. I understand that this is a proof of concept and that you hope to prove this approach viable before doing all of the spec work. Another path could be to add this in a new |
@foolip filed an RFC for this at web-platform-tests/rfcs#180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @foolip wrote above, this (as with additions to testdriver generally) requires an RFC to be acceptable.
The discussion from a policy point of view should live there, but my view is likely in line with what was written/discussed in web-platform-tests/rfcs#172.
My thoughts align with others above re: RFC in WebDriver and/or AOM. IIRC, the initial justification for this feature was proposed in:
It would be nice to see some output comparisons between Chromium's |
Add
get_accessibility_tree
endpoint totestdriver
. In this change the endpoint presents the interface in Chrome Devtools Protocol'sAccessibility.getFullAXTree
.This API can be used to test aria attributes like aria-orientation and aria-invalid and that the browser uses the correct default values when they are not set in the html element.
Related: web-platform-tests/interop-accessibility#51