webnn: Remove sync methods #44572
Closed
webnn: Remove sync methods #44572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5292884
branch
4 times, most recently
from
3cc3c22
to
a40adf2
Compare
See webmachinelearning/webnn#548 Deletes all sync methods and simplifies the names of all "Async" methods - e.g. BuildAsync() -> Build() Bug: 40283536, 41481333 Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1261223}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5292884
branch
from
a40adf2
to
542892d
Compare
wpt-pr-bot
approved these changes
Feb 15, 2024
|
Change reverted in chromium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See webmachinelearning/webnn#548
Deletes all sync methods and simplifies the names of all "Async"
methods - e.g. BuildAsync() -> Build()
Bug: 40283536, 41481333
Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261223}
Revert "webnn: Remove sync methods"
This reverts commit a3e84dde09e099bebbe4793ffaa70679168130d6.
Reason for revert: One Win 11 , blink_wpt_tests are failing consistently since https://ci.chromium.org/ui/p/chromium/builders/ci/Win11%20Tests%20x64/19453/blamelist This CL seems to be a candidate for causing this.
Original change's description:
Bug: 40283536, 41481333
Change-Id: Ib59afe686ae8e18bcad63ff7d15816cd93090f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301381
Owners-Override: Markus Heintz markusheintz@google.com
Auto-Submit: Markus Heintz markusheintz@google.com
Commit-Queue: Markus Heintz markusheintz@google.com
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Cr-Commit-Position: refs/heads/main@{#1261576}