Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc wpt: add test for direction-based filtering of codecs #44604

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 15, 2024

to supplement the discussion in
w3c/webrtc-pc#2937

BUG=324930413

Change-Id: Iebf02aade64030e11590af211fa7bc90f976c592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293562
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262367}

to supplement the discussion in
  w3c/webrtc-pc#2937

BUG=324930413

Change-Id: Iebf02aade64030e11590af211fa7bc90f976c592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293562
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262367}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@fippo
Copy link
Contributor

fippo commented Feb 19, 2024

https://github.com/web-platform-tests/wpt/runs/21730292331 fails due to

css/css-highlight-api/historical.window.js: Testcase file must have a link to a spec (MISSING-LINK)

which seems quite unrelated?

@jonathan-j-lee
Copy link
Contributor

https://github.com/web-platform-tests/wpt/runs/21730292331 fails due to

css/css-highlight-api/historical.window.js: Testcase file must have a link to a spec (MISSING-LINK)

which seems quite unrelated?

Yes, should be unblocked by #44656. Retrying the build now.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8d72cde into master Feb 20, 2024
19 of 21 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5293562 branch February 20, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants