Remove getHTML() shouldn't branch on shadow root's mode #45624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with clonable and delegatesFocus, serializable is an explicit API and therefore fine from an encapsulation point of view. For whatwg/html#10260.
5 tasks
rniwa
approved these changes
Apr 9, 2024
mfreed7
approved these changes
Apr 9, 2024
annevk
added a commit
to whatwg/html
that referenced
this pull request
Apr 10, 2024
I missed this in review but my understanding of the discussion we had around #8867 was that the contract would be the same for open and closed shadow roots. Tests: web-platform-tests/wpt#45624.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 12, 2024
Per the spec change: whatwg/html#10260 This is a small behavior change. If `{serializableShadowRoots:true}` and a given shadow root is `serializable`, then serialize it, even if it is closed. Tests should flow in from this upstream WPT change: web-platform-tests/wpt#45624 Bug: 41490936 Change-Id: I85f239599dda60637ff6301d1a501f9cce24a861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5448166 Reviewed-by: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1286531}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with clonable and delegatesFocus, serializable is an explicit API and therefore fine from an encapsulation point of view.
For whatwg/html#10260.