-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File URLs with repeated slsashes #4762
Conversation
Notifying @Sebmaster, @domenic, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) These tests will be available on w3c-test.org shortly after they are approved by a repository collaborator. |
2b0e379
to
800055d
Compare
Chrome (unstable channel)Testing web-platform-tests at revision 81bc17b All results/url/url-constructor.html
/url/url-origin.html
/url/a-element-xhtml.xhtml
/url/a-element.html
/url/a-element-origin.html
/url/a-element-origin-xhtml.xhtml
|
url/urltestdata.json
Outdated
"input": "file:////////", | ||
"base": "about:blank", | ||
"href": "file:///", | ||
"origin": "null", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Origin should be omitted for file URL tests because of https://url.spec.whatwg.org/#origin's "exercise for the reader"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I misunderstood about it. Thanks, I've updated :)
Repeated slashes should be ignored in not only the http scheme, but also the file scheme as well. Tests: web-platform-tests/wpt#4762 Fixes: whatwg#232
800055d
to
9a313f2
Compare
These look good. Maybe also a mixture of \ and /? And also one with \ ending in a non-? |
It also seems you need to rebase, probably due to other tests landing :/ If that's too problematic I can do that for you tomorrow. |
9a313f2
to
c452438
Compare
Firefox (nightly channel)Testing web-platform-tests at revision 9d1298b1106ef1d4d8e274286bbcc55df608f0f2 All results/url/url-constructor.html
/url/url-origin.html
/url/a-element-xhtml.xhtml
/url/a-element.html
/url/a-element-origin.html
/url/a-element-origin-xhtml.xhtml
|
c452438
to
a0c9c99
Compare
Related links + The URL Standard change: whatwg/url#234 + The original bug report: whatwg/url#232
a0c9c99
to
25a05e1
Compare
@annevk Rebase is done, but I couldn't get |
It seems GitHub ate the slash. I meant non- Also whatwg/url#232 (comment) makes some very good points that need to be addressed one way or another. |
Apart from that comment by @rmisev, I think we should also test a non-null file base URL with and without a host, and then various forms of slashed input (with/without localhost) against that. Hope this is not too discouraging. Also, there's no rush whatsoever, we should take our time to get this right. |
Closes #4762 by superseding it. URL Standard: whatwg/url#232.
Closes #4762 by superseding it. URL Standard: whatwg/url#232.
Related links
cc @annevk