[idlharness] Support testing of [LegacyWindowAlias] extended attribute #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new test passes in Chromium with this ad-hoc IDL file: |
Firefox (nightly)Testing web-platform-tests at revision 30199ad |
Sauce (safari)Testing web-platform-tests at revision 30199ad |
Chrome (unstable)Testing web-platform-tests at revision 30199ad |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 30199ad |
tobie
reviewed
May 17, 2017
resources/idlharness.js
Outdated
| throw "Invalid IDL: LegacyWindowAlias extended attribute on non-interface " + this.name; | ||
| } | ||
| if (this.exposureSet.indexOf("Window") === -1) { | ||
| throw "Invalid IDL: LegacyWindowAlias extended attribute on " + this.name + " but not exposed in Window"; |
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
tobie
reviewed
May 17, 2017
resources/idlharness.js
Outdated
|
|
||
| // OK now actually check the aliases... | ||
| for (var alias of aliases) { | ||
| assert_true(alias in self, alias + " should exist"); |
There was a problem hiding this comment.
Isn't that going to fail in workers?
|
@tobie PTAL |
zcorpan
added a commit
that referenced
this pull request
May 18, 2017
This is on top of #5966. Follows w3c/fxtf-drafts#167
zcorpan
added a commit
that referenced
this pull request
May 18, 2017
This is on top of #5966. Follows w3c/fxtf-drafts#167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows whatwg/webidl#364