Make wptrun fail correctly when certutil not found #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes wptrun correctly handle the case where it can’t find
the certutil binary.
Without this change you end up with the value of `path` being `None`
when it reaches this part of the tools/browserutils/browser.py code:
if os.path.splitdrive(path)[1].split(os.path.sep) == ["", "Windows", "system32", "certutil.exe"]:
... which results in:
AttributeError: 'NoneType' object has no attribute 'split'
So this change just early-returns `None` from there if `path` is `None`.
Firefox (nightly)Testing web-platform-tests at revision 030bba7 |
Sauce (safari)Testing web-platform-tests at revision 030bba7 |
Chrome (unstable)Testing web-platform-tests at revision 030bba7 |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 030bba7 |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes wptrun correctly handle the case where it can’t find
the certutil binary.
Without this change you end up with the value of
pathbeingNonewhen it reaches this part of the tools/browserutils/browser.py code:
... which results in:
So this change just early-returns
Nonefrom there ifpathisNone.This change is