[BUGFIX] Guard LocalizationUtility::translate with (string) cast
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LocalizationUtility::translate()` is used in several places to translate something. The method may return a string or null, where as the used places usual expects to have a valid string afterwards. For example, if the return value is null and used to pass it to another method like `htmlspecialchars()` this will violates added argument types with PHP 8.0. To avoid emitted PHP warnings call to this method is guarded with a explicit `(string)` type cast to mitigate this issue. Releases: main, 3.0
sbuerk
changed the title
LocalizationUtility::translate with (string) castLocalizationUtility::translate with (string) cast (Backport)
sbuerk
changed the title
LocalizationUtility::translate with (string) cast (Backport)LocalizationUtility::translate with (string) cast
calien666
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LocalizationUtility::translate()is usedin several places to translate something. The
method may return a string or null, where as
the used places usual expects to have a valid
string afterwards. For example, if the return
value is null and used to pass it to another
method like
htmlspecialchars()this willviolates added argument types with PHP 8.0.
To avoid emitted PHP warnings call to this
method is guarded with a explicit
(string)type cast to mitigate this issue.
Releases: main, 3.0