Improve usage readability #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pixelbrackets Please rebase your branch to the latest main, as you forgot allow editing by us and I can't do. If you have done, the pipelines will succeed. |
Action icons dont have a fixed color set, in order to let TYPO3 set the desired color - black in list actions, white in toolbar infos. Change the DeepL SVG to not use black in all places.
pixelbrackets
force-pushed
the
usage-readability
branch
from
6c4b545 to
4bd22c2
Compare
|
@calien666 »Allow edit by maintainers« was/is active already. Branch is rebased and green again :) |
|
@calien666 The PR is missing one approving review yet - are you able to do this? |
|
Done by #358 Thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make usage messages more readable (like “48.476 of 5.000.000” instead of “48476 / 5000000”).
Also adapt the action icon SVG similar to existing action icons of the TYPO3 core (these dont set fixed colors in order to let them change as needed in the context). Right now the DeepL icon is the only one in the system information bar which is black, this PR will fix this.
Before
After
