Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Ensure failing php-cs-fixer within Github Action pipeline #384

Merged
merged 2 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/testcore12.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
run: "Build/Scripts/runTests.sh -t 12 -p ${{ matrix.php-version }} -s lintPhp"

- name: "Validate CGL"
run: "Build/Scripts/runTests.sh -t 12 -p ${{ matrix.php-version }} -s cgl"
run: "Build/Scripts/runTests.sh -t 12 -p ${{ matrix.php-version }} -s cgl -n"

- name: "Ensure tests methods do not start with \"test\""
run: "Build/Scripts/runTests.sh -t 12 -p ${{ matrix.php-version }} -s checkTestMethodsPrefix"
Expand Down
4 changes: 2 additions & 2 deletions Tests/Functional/AbstractDeepLTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@

namespace WebVision\Deepltranslate\Core\Tests\Functional;

use RuntimeException;
use Closure;
use Exception;
use DeepL\Translator;
use DeepL\TranslatorOptions;
use Exception;
use phpmock\phpunit\PHPMock;
use Psr\Log\NullLogger;
use Ramsey\Uuid\Uuid;
use RuntimeException;
use Symfony\Component\DependencyInjection\Container;
use TYPO3\CMS\Core\Utility\StringUtility;
use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
Expand Down
6 changes: 3 additions & 3 deletions Tests/Functional/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@

namespace WebVision\Deepltranslate\Core\Tests\Functional;

use PHPUnit\Framework\Attributes\CoversClass;
use WebVision\Deepltranslate\Core\Client;
use PHPUnit\Framework\Attributes\Test;
use DateTime;
use DeepL\GlossaryEntries;
use DeepL\GlossaryInfo;
use DeepL\GlossaryLanguagePair;
use DeepL\Language;
use DeepL\TextResult;
use Helmich\JsonAssert\JsonAssertions;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\Test;
use WebVision\Deepltranslate\Core\Client;
use WebVision\Deepltranslate\Core\ClientInterface;

#[CoversClass(Client::class)]
Expand Down
2 changes: 1 addition & 1 deletion Tests/Functional/Services/DeeplServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace WebVision\Deepltranslate\Core\Tests\Functional\Services;

use DeepL\Language;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\Test;
use DeepL\Language;
use WebVision\Deepltranslate\Core\Domain\Dto\TranslateContext;
use WebVision\Deepltranslate\Core\Service\DeeplService;
use WebVision\Deepltranslate\Core\Service\ProcessingInstruction;
Expand Down
2 changes: 1 addition & 1 deletion Tests/Functional/Services/UsageServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace WebVision\Deepltranslate\Core\Tests\Functional\Services;

use PHPUnit\Framework\Attributes\Test;
use DeepL\Usage;
use DeepL\UsageDetail;
use PHPUnit\Framework\Attributes\Test;
use WebVision\Deepltranslate\Core\Service\DeeplService;
use WebVision\Deepltranslate\Core\Service\ProcessingInstruction;
use WebVision\Deepltranslate\Core\Service\UsageService;
Expand Down