[TASK] Make ProcessingInstructions public service for 4.x #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As other services can use the DeeplService and translate by their own, it's necessary to be able to override the ProcessingInstruction setting DeepL mode to true. As this is not the default and inside the core extension only needed for the command map, the service has to be made public, allowing external services adjusting the instructions.
|
Needs to be upported to main (5.x) also afterwards. Added version labels to make that clear along with changing the pull-request title. |
sbuerk
changed the title
sbuerk
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As other services can use the DeeplService and translate by their own, it's necessary to be able to override the ProcessingInstruction setting DeepL mode to true. As this is not the default and inside the core extension only needed for the command map, the service has to be made public, allowing external services adjusting the instructions.