fix: switch upload-api to node16 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
force-pushed
the
fix/w3infra-incompat
branch
from
1a01bf4 to
7a63e29
Compare
gobengo
reviewed
Mar 8, 2023
| @@ -34,7 +34,7 @@ jobs: | |||
| - name: Setup | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 18 | |||
There was a problem hiding this comment.
I'd love to matrix test w/ both 16 and 18 if possible
There was a problem hiding this comment.
I'm not sure it is worth it, because doing it in ucanto increases test time significantly. If we ever find that something does not work in node 18 lets add then.
gobengo
approved these changes
Mar 8, 2023
Gozala
pushed a commit
that referenced
this pull request
Mar 8, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.3](upload-api-v1.0.2...upload-api-v1.0.3) (2023-03-08) ### Bug Fixes * switch upload-api to node16 ([#509](#509)) ([698a033](698a033)) * types so that w3infra would have been evident ([#507](#507)) ([544a838](544a838)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Running tests in w3infra failed because `Blob` is not in node16. Change ci to use node 16 for upload-api to avoid this problem.
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.3](upload-api-v1.0.2...upload-api-v1.0.3) (2023-03-08) ### Bug Fixes * switch upload-api to node16 ([#509](#509)) ([92a708b](92a708b)) * types so that w3infra would have been evident ([#507](#507)) ([d694669](d694669)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
this gives us a soft restriction on the number of spaces a user can create - we'll enforce this server-side in storacha#704
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](storacha/w3ui@w3console-v1.4.1...w3console-v1.5.0) (2023-05-09) ### Features * add warnings about the public and permanent nature of w3up uploads ([storacha#502](storacha/w3ui#502)) ([6cc58f8](storacha/w3ui@6cc58f8)), closes [storacha#464](storacha/w3ui#464) * get w3console looking acceptable on mobile ([storacha#500](storacha/w3ui#500)) ([118cb22](storacha/w3ui@118cb22)) * remove space creator from sidebar ([storacha#509](storacha/w3ui#509)) ([40bc621](storacha/w3ui@40bc621)) * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([e1ee301](storacha/w3ui@e1ee301)) * upload progress ([storacha#499](storacha/w3ui#499)) ([6c9de97](storacha/w3ui@6c9de97)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([78aee2a](storacha/w3ui@78aee2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
this gives us a soft restriction on the number of spaces a user can create - we'll enforce this server-side in storacha#704
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](storacha/w3ui@w3console-v1.4.1...w3console-v1.5.0) (2023-05-09) ### Features * add warnings about the public and permanent nature of w3up uploads ([storacha#502](storacha/w3ui#502)) ([ad0632c](storacha/w3ui@ad0632c)), closes [storacha#464](storacha/w3ui#464) * get w3console looking acceptable on mobile ([storacha#500](storacha/w3ui#500)) ([3e512df](storacha/w3ui@3e512df)) * remove space creator from sidebar ([storacha#509](storacha/w3ui#509)) ([d5f5536](storacha/w3ui@d5f5536)) * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests in w3infra failed because
Blobis not in node16. Change ci to use node 16 for upload-api to avoid this problem.