Skip to content

Commit

Permalink
fix!: remove non read-only ens methods (#6084)
Browse files Browse the repository at this point in the history
* fix!: remove non read-only ens methods

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>

* fix integration tests

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>

* fix tests

* fix tests

* remove unnecessary tests

* increase coverage

* fix changelog

* skip internal provider test for now

---------

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
  • Loading branch information
5 people authored May 30, 2023
1 parent 8c5ea34 commit 408332d
Show file tree
Hide file tree
Showing 21 changed files with 1,380 additions and 2,157 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -1465,6 +1465,7 @@ should use 4.0.1-alpha.0 for testing.
### Breaking Changes

- dropped support for NodeJs@14
- removed non read-only methods from ens package

### Added

Expand Down
4 changes: 4 additions & 0 deletions packages/web3-eth-ens/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bug fix of `checkNetwork` in ENS (#5988)

## [Unreleased]

### Removed

- Removed non read-only methods (#6084)
211 changes: 0 additions & 211 deletions packages/web3-eth-ens/src/abi/ens/ENSRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,36 +17,6 @@ along with web3.js. If not, see <http://www.gnu.org/licenses/>.

// https://github.com/ensdomains/ens-contracts/blob/master/contracts/registry/ENSRegistry.sol
export const ENSRegistryAbi = [
{
inputs: [],
stateMutability: 'nonpayable',
type: 'constructor',
},
{
anonymous: false,
inputs: [
{
indexed: true,
internalType: 'address',
name: 'owner',
type: 'address',
},
{
indexed: true,
internalType: 'address',
name: 'operator',
type: 'address',
},
{
indexed: false,
internalType: 'bool',
name: 'approved',
type: 'bool',
},
],
name: 'ApprovalForAll',
type: 'event',
},
{
anonymous: false,
inputs: [
Expand Down Expand Up @@ -91,25 +61,6 @@ export const ENSRegistryAbi = [
name: 'NewResolver',
type: 'event',
},
{
anonymous: false,
inputs: [
{
indexed: true,
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
indexed: false,
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'NewTTL',
type: 'event',
},
{
anonymous: false,
inputs: [
Expand Down Expand Up @@ -210,168 +161,6 @@ export const ENSRegistryAbi = [
stateMutability: 'view',
type: 'function',
},
{
inputs: [
{
internalType: 'address',
name: 'operator',
type: 'address',
},
{
internalType: 'bool',
name: 'approved',
type: 'bool',
},
],
name: 'setApprovalForAll',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
],
name: 'setOwner',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
{
internalType: 'address',
name: 'resolver',
type: 'address',
},
{
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'setRecord',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'address',
name: 'resolver',
type: 'address',
},
],
name: 'setResolver',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'bytes32',
name: 'label',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
],
name: 'setSubnodeOwner',
outputs: [
{
internalType: 'bytes32',
name: '',
type: 'bytes32',
},
],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'bytes32',
name: 'label',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
{
internalType: 'address',
name: 'resolver',
type: 'address',
},
{
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'setSubnodeRecord',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'setTTL',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
Expand Down
Loading

0 comments on commit 408332d

Please sign in to comment.