updating checksum

web3 · Jun 11, 2021 · 5fec5ff · 5fec5ff
1 parent 39ff2c0
commit 5fec5ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/web3-eth-accounts/src/index.js b/packages/web3-eth-accounts/src/index.js
@@ -292,7 +292,8 @@ Accounts.prototype.recoverTransaction = function recoverTransaction(rawTx, txOpt
     // Rely on EthereumJs/tx to determine the type of transaction
     const data = Buffer.from(rawTx.slice(2), "hex")
     const tx = TransactionFactory.fromSerializedData(data);
-    return tx.getSenderAddress().toString("hex");
+    //update checksum
+    return utils.toChecksumAddress(tx.getSenderAddress().toString("hex"));
 };
 /* jshint ignore:end */
 

diff --git a/test/eth.accounts.signTransaction.js b/test/eth.accounts.signTransaction.js
@@ -738,7 +738,7 @@ describe("eth", function () {
                     var testAccount = ethAccounts.privateKeyToAccount(test.privateKey);
                     assert.equal(testAccount.address, test.address);
                     testAccount.signTransaction(test.transaction).then(function (tx) {
-                        assert.equal(ethAccounts.recoverTransaction(tx.rawTransaction), test.address.toLowerCase());
+                        assert.equal(ethAccounts.recoverTransaction(tx.rawTransaction), test.address);
                         done();
                     })
                     .catch(e => {