Skip to content

Commit

Permalink
Merge branch '1.x' into release/1.2.6
Browse files Browse the repository at this point in the history
  • Loading branch information
nivida authored Jan 31, 2020
2 parents c7b8b7b + a121b6f commit 9cdb435
Show file tree
Hide file tree
Showing 28 changed files with 1,498 additions and 96 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ packages/web3/dist/
lerna-debug.log
!./dist/web3.min.js
.nyc_output/
build/
contracts/
migrations/
truffle-config.js
test/config/ensAddresses.json
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ matrix:
env: TEST=e2e_ganache
- node_js: 10
env: TEST=e2e_mosaic
- node_js: 10
env: TEST=e2e_ens
- node_js: 10
env: TEST=e2e_browsers
addons:
Expand Down
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,18 @@ Released with 1.0.0-beta.37 code base.
- ENS registry addresses updated (#3353, https://medium.com/the-ethereum-name-service/ens-registry-migration-bug-fix-new-features-64379193a5a)

## [Unreleased]

## [1.2.6]

### Added

- ENS module extended with the possibility to add a custom registry (#3301)
- Görli testnet ENS registry added to the known registries (#3338)

### Changed

- Ensure '0x' prefix is existing for Accounts.sign and Accounts.privateKeyToAccount (#3041)

### Fixed

- Add missing subscription.on('connected') TS type definition (#3319)
4 changes: 2 additions & 2 deletions docs/include_package-net.rst
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Example

.. code-block:: javascript
web3.eth.isListening()
web3.eth.net.isListening()
.then(console.log);
> true
Expand Down Expand Up @@ -101,6 +101,6 @@ Example

.. code-block:: javascript
web3.eth.getPeerCount()
web3.eth.net.getPeerCount()
.then(console.log);
> 25
3 changes: 2 additions & 1 deletion docs/web3-eth-accounts.rst
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ privateKeyToAccount

.. code-block:: javascript
web3.eth.accounts.privateKeyToAccount(privateKey);
web3.eth.accounts.privateKeyToAccount(privateKey [, ignoreLength ]);
Creates an account object from a private key.

Expand All @@ -103,6 +103,7 @@ Parameters
----------

1. ``privateKey`` - ``String``: The private key to convert.
1. ``ignoreLength`` - ``Boolean``: If set to true does the ``privateKey`` length not get validated.

-------
Returns
Expand Down
29 changes: 29 additions & 0 deletions docs/web3-eth-ens.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,35 @@ The ``web3.eth.ens`` functions let you interacting with ENS.

------------------------------------------------------------------------------

registryAddress
=====================

.. code-block:: javascript
web3.eth.ens.registryAddress;
The ``registryAddress`` property can be used to define a custom registry address when you are connected to an unknown chain.

.. note::
If no address is defined will it try to detect the registry on the chain you are currently connected with and on the call of ``setProvider`` in the Eth module will it keep the defined address and use it for the ENS module.

-------
Returns
-------

``String`` - The address of the custom registry.

-------
Example
-------

.. code-block:: javascript
web3.eth.ens.registryAddress;
> "0x314159265dD8dbb310642f98f50C066173C1259b"
------------------------------------------------------------------------------

registry
=====================

Expand Down
Loading

0 comments on commit 9cdb435

Please sign in to comment.