addressing feedback

package.json

@@ -101,7 +101,6 @@
         "@types/bignumber.js": "^4.0.2",
         "@types/bn.js": "^4.11.6",
         "@types/node": "^12.12.68",
-        "@types/underscore": "^1.10.24",
         "babel-loader": "^8.1.0",
         "bignumber.js": "^9.0.1",
         "bn.js": "^4.11.9",
@@ -132,7 +131,6 @@
         "sandboxed-module": "^2.0.4",
         "ts-node": "^9.0.0",
         "typescript": "^3.9.7",
-        "underscore": "1.12.1",
         "wait-port": "^0.2.9",
         "webpack": "^4.44.2",
         "webpack-cli": "^3.3.12"

packages/web3-bzz/package.json

@@ -17,8 +17,7 @@
     "dependencies": {
         "@types/node": "^12.12.6",
         "got": "9.6.0",
-        "swarm-js": "^0.1.40",
-        "underscore": "1.12.1"
+        "swarm-js": "^0.1.40"
     },
     "devDependencies": {
         "dtslint": "^3.4.1",

packages/web3-bzz/src/index.js

@@ -22,7 +22,6 @@
 
 "use strict";
 
-
 var swarm = require("swarm-js");
 
 

packages/web3-core-helpers/package.json

@@ -14,7 +14,6 @@
     },
     "main": "lib/index.js",
     "dependencies": {
-        "underscore": "1.12.1",
         "web3-eth-iban": "1.3.6",
         "web3-utils": "1.3.6"
     },

packages/web3-core-method/package.json

@@ -15,7 +15,6 @@
     "main": "lib/index.js",
     "dependencies": {
         "@ethersproject/transactions": "^5.0.0-beta.135",
-        "underscore": "1.12.1",
         "web3-core-helpers": "1.3.6",
         "web3-core-promievent": "1.3.6",
         "web3-core-subscriptions": "1.3.6",

packages/web3-core-method/src/index.js

@@ -179,7 +179,6 @@ Method.prototype.formatOutput = function (result) {
 Method.prototype.toPayload = function (args) {
     var call = this.getCall(args);
     var callback = this.extractCallback(args);
-    //check if last args is a function, if so pop it out.
 
     var params = this.formatInput(args);
     this.validateArgs(params);

packages/web3-core-requestmanager/package.json

@@ -12,7 +12,6 @@
         "compile": "tsc -b tsconfig.json"
     },
     "dependencies": {
-        "underscore": "1.12.1",
         "util": "^0.12.0",
         "web3-core-helpers": "1.3.6",
         "web3-providers-http": "1.3.6",

packages/web3-core-subscriptions/package.json

@@ -15,7 +15,6 @@
     "main": "lib/index.js",
     "dependencies": {
         "eventemitter3": "4.0.4",
-        "underscore": "1.12.1",
         "web3-core-helpers": "1.3.6"
     },
     "devDependencies": {

packages/web3-core-subscriptions/src/subscription.js

@@ -26,7 +26,7 @@ var errors = require('web3-core-helpers').errors;
 var EventEmitter = require('eventemitter3');
 var formatters = require('web3-core-helpers').formatters;
 
-function identity(value) {
+function identity(value) { //used to return the exact same replica of the value given to it as the argument
     return value;
 }
 

packages/web3-eth-abi/package.json

@@ -15,7 +15,6 @@
     "main": "lib/index.js",
     "dependencies": {
         "@ethersproject/abi": "5.0.7",
-        "underscore": "1.12.1",
         "web3-utils": "1.3.6"
     },
     "devDependencies": {

packages/web3-eth-accounts/package.json

@@ -19,7 +19,6 @@
         "ethereumjs-common": "^1.3.2",
         "ethereumjs-tx": "^2.1.1",
         "scrypt-js": "^3.0.1",
-        "underscore": "1.12.1",
         "uuid": "3.3.2",
         "web3-core": "1.3.6",
         "web3-core-helpers": "1.3.6",

packages/web3-eth-contract/package.json

@@ -15,7 +15,6 @@
     "main": "lib/index.js",
     "dependencies": {
         "@types/bn.js": "^4.11.5",
-        "underscore": "1.12.1",
         "web3-core": "1.3.6",
         "web3-core-helpers": "1.3.6",
         "web3-core-method": "1.3.6",

packages/web3-eth-ens/package.json

@@ -16,7 +16,6 @@
     "dependencies": {
         "content-hash": "^2.5.2",
         "eth-ens-namehash": "2.0.8",
-        "underscore": "1.12.1",
         "web3-core": "1.3.6",
         "web3-core-helpers": "1.3.6",
         "web3-core-promievent": "1.3.6",

packages/web3-eth/package.json

@@ -14,7 +14,6 @@
     },
     "main": "lib/index.js",
     "dependencies": {
-        "underscore": "1.12.1",
         "web3-core": "1.3.6",
         "web3-core-helpers": "1.3.6",
         "web3-core-method": "1.3.6",

packages/web3-providers-ipc/package.json

@@ -15,7 +15,6 @@
     "main": "lib/index.js",
     "dependencies": {
         "oboe": "2.1.5",
-        "underscore": "1.12.1",
         "web3-core-helpers": "1.3.6"
     },
     "devDependencies": {

packages/web3-providers-ws/package.json

@@ -15,7 +15,6 @@
   "main": "lib/index.js",
   "dependencies": {
     "eventemitter3": "4.0.4",
-    "underscore": "1.12.1",
     "web3-core-helpers": "1.3.6",
     "websocket": "^1.0.32"
   },

packages/web3-utils/package.json

@@ -20,7 +20,6 @@
         "ethjs-unit": "0.1.6",
         "number-to-bn": "1.7.0",
         "randombytes": "^2.1.0",
-        "underscore": "1.12.1",
         "utf8": "3.0.0"
     },
     "devDependencies": {

test/abi.decodeParameter.js

@@ -348,10 +348,9 @@ describe('lib/solidity/coder', function () {
                 var result = coder.decodeParameters(t.types, t.values);
 
                 var resultArray = [];
-                for (var key in result) {
-                       if(isFinite(key)) 
-                            resultArray.push(result[key]);
-                }
+                Object.keys(result).map(key => {
+                     if(isFinite(key)) resultArray.push(result[key])
+              });