Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status to getTransactionReceipt in docs #1488

Closed

Conversation

gurbraj
Copy link

@gurbraj gurbraj commented Mar 23, 2018

As per https://ethereum.stackexchange.com/a/6003, this PR adds status as a field to the return of web3.eth.getTransactionReceipt in docs.

@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage remained the same at 85.746% when pulling 553d897 on gurbraj:odg/add-status-to-getTransactionReceipt-docs into e69054d on ethereum:1.0.

@frozeman
Copy link
Contributor

We should actually convert the status object into a boolean in the formatters.js, you could do that, and please remove the lock file changes from your PR.

@frozeman
Copy link
Contributor

I fixed it myself in 85f4534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants