Web3 shh typings #2128
Merged
Web3 shh typings #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nivida
suggested changes
Dec 17, 2018
| @@ -63,7 +63,7 @@ Returns | |||
| ------- | |||
|
|
|||
|
|
|||
| ``String`` - The version of the current whisper running. | |||
| ``Promise`` returns ``String`` - The version of the current whisper running. | |||
There was a problem hiding this comment.
I would like this syntax more: Promise<String> 🤔
There was a problem hiding this comment.
I would as well but the web3-eth describes it like this so i wanted to keep it consistent
https://web3js.readthedocs.io/en/1.0/web3-eth.html#getcoinbase
There was a problem hiding this comment.
Okay then I'll change that later everywhere :)
nivida
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web3-shh full typing's.
All typing's have been written, i have brought
web3-coreinto the dependencies as it was a child dependency anyway, as was brought it by other packages so this is not a breaking change. This should of really been a parent dependency from the start.Cheers