Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final web3 types PR #2133

Merged
merged 15 commits into from
Dec 18, 2018
Merged

Final web3 types PR #2133

merged 15 commits into from
Dec 18, 2018

Conversation

joshstevens19
Copy link
Contributor

@joshstevens19 joshstevens19 commented Dec 18, 2018

Final PR for the types, i have updated the README, PR template and gone through to double double check all the types. I have also made it as reusable as possible.

@joshstevens19 joshstevens19 changed the title Final types Final web3 types PR Dec 18, 2018
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
packages/web3-eth-accounts/types/index.d.ts Show resolved Hide resolved
packages/web3-bzz/package.json Show resolved Hide resolved
@nivida nivida merged commit f7a607d into web3:ethereumProvider Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants