Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/types reference node types #2261

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Fix/types reference node types #2261

merged 3 commits into from
Feb 4, 2019

Conversation

joshstevens19
Copy link
Contributor

Description

Cannot find name 'Buffer'. Can't find module 'net'. issues when installing web3 on front-end typescript apps, current work around is to install @types/node and add the types to the tsconfig.app.json this PR resolves all of that and you don't need to install those types on every typescript project you install web3 now.

#2260

Type of change

  • Bug fix
  • New feature
  • Breaking change

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@nivida nivida added the Types Incorrect or missing types label Feb 3, 2019
@nivida nivida merged commit 9063020 into web3:1.0 Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants