Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-2293]-Adding clarification of how data needs to be prefix #2295

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

axelgalicia
Copy link

@axelgalicia axelgalicia commented Feb 2, 2019

Adding clarification of data prefix for sign method.

This clarification helps the users using the sign method that there is a need to prefix the data.

Fixes #2293

Type of change

  • [ x] Bug fix

Checklist:

  • [ x] I have selected the correct base branch.
  • [ x] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly in hard-to-understand areas.
  • [ x] I have made corresponding changes to the documentation.
  • [ x] My changes generate no warnings.
  • [ x] I have updated or added types for all modules I've changed
  • [ x] Any dependent changes have been merged and published in downstream modules.
  • [ x] I ran npm run test in the root folder with success and extended the tests if necessary.
  • [ x] I ran npm run build in the root folder and tested it in the browser and with node.
  • [ x] I ran npm run dtslint in the root folder and tested that all my types are correct
  • [ x] I have tested my code on the live network.

@axelgalicia axelgalicia changed the title [GH-2293]-Adding clarification of how data needs to be prefix before … [GH-2293]-Adding clarification of how data needs to be prefix Feb 2, 2019
@nivida nivida added the Documentation Relates to project wiki or documentation label Feb 3, 2019
@nivida nivida merged commit d7054bd into web3:1.0 Feb 4, 2019
@axelgalicia
Copy link
Author

Hello @nivida , I would like to be a formal contributor of the project. Do you know how can I do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mention of the "Ethereum Signed Message" prefix to the eth.personal.sign documentation
2 participants