Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomProvider #2426

Merged
merged 8 commits into from
Feb 28, 2019
Merged

CustomProvider #2426

merged 8 commits into from
Feb 28, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 26, 2019 •
edited
Loading

Description

Fixes #2266

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Feb 26, 2019
@coveralls
Copy link

coveralls commented Feb 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 94.644% when pulling 91d925a on issue/2266 into b88ab82 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Feb 27, 2019
@nivida nivida mentioned this pull request Feb 27, 2019
Closed
@nivida
Copy link
Contributor Author

nivida commented Feb 28, 2019 •
edited
Loading

I've tested it with the mainnet over the provider-engine from MetaMask and it works.

@nivida nivida merged commit 2eeedca into 1.0 Feb 28, 2019
@nivida nivida deleted the issue/2266 branch February 28, 2019 09:07
@wbt wbt mentioned this pull request Jul 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Truffle and Ganache providers, Metamask Provider Engine no longer accepted as valid by web3
2 participants
@nivida @coveralls