Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign needed to have a signature on typing's + fix incorrect docs #2471

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Sign needed to have a signature on typing's + fix incorrect docs #2471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbf1f63
fix: add signature on `Sign`
joshstevens19 Mar 7, 2019
4822774
fix: resolve documantion as it always returns a object
joshstevens19 Mar 7, 2019
1cf3791
Merge branch '1.0' into @types/sign
nivida Mar 12, 2019
12a105c
Merge branch '1.0' into @types/sign
joshstevens19 Mar 18, 2019
88ad4c2
Merge branch '1.0' into @types/sign
nivida Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/web3-eth-accounts.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ Parameters
Returns
-------

``String|Object``: The signed data RLP encoded signature, or if ``returnSignature`` is ``true`` the signature values as follows:
``Object``: The signed data RLP encoded signature, or if ``returnSignature`` is ``true`` the signature values as follows:
- ``message`` - ``String``: The the given message.
- ``messageHash`` - ``String``: The hash of the given message.
- ``r`` - ``String``: First 32 bytes of the signature
Expand Down
1 change: 1 addition & 0 deletions packages/web3-eth-accounts/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,5 @@ export interface EncryptedKeystoreV3Json {

export interface Sign extends SignedTransaction {
message: string;
signature: string;
}