Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types for HttpProvider options updated #2575

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Types for HttpProvider options updated #2575

merged 1 commit into from
Mar 25, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 25, 2019 •
edited
Loading

Description

Fixes and improves the HttpProvider options types.

Type of change

  • Types

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added the Types Incorrect or missing types label Mar 25, 2019
@nivida nivida merged commit a08445b into 1.0 Mar 25, 2019
@nivida nivida deleted the fix/http-options-type branch March 25, 2019 15:15
@joshstevens19 joshstevens19 mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nivida