eth.subscribe types improvement #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| subscribe(type: 'syncing', options?: null, callback?: (error: Error, result: any) => void): Subscription<any>; | ||
| subscribe(type: 'newBlockHeaders', options?: null, callback?: (error: Error, blockHeader: BlockHeader) => void): Subscription<BlockHeader>; | ||
| subscribe(type: 'pendingTransactions', options?: null, callback?: (error: Error, transactionHash: string) => void): Subscription<string>; | ||
| subscribe( |
There was a problem hiding this comment.
Making this generic actually loses a lot of good typings for these methods. It before use to map a proper typed single response depending on your type string you supply which is the best kinds of types., the less generic in typings like this the better it is. This will make calling this method super hard in TypeScript world, near impossible to get proper compile time errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2583
Type of change
Checklist:
npm run testin the root folder with success and extended the tests if necessary.npm run buildin the root folder and tested it in the browser and with node.npm run dtslintin the root folder and tested that all my types are correct