Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPendingTransactions implemented in web3-core-methods #2655

Merged
merged 5 commits into from
Apr 8, 2019

Conversation

princesinha19
Copy link
Contributor

@princesinha19 princesinha19 commented Apr 5, 2019

Description

Inside transaction in web3-core-methods pending transactions was missing. So, I implemented that method.
eth.getPendingTransactions will give pending transaction array.

Type of change

  • New feature

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage increased (+0.002%) to 95.376% when pulling 414148e on princesinha19:pending_transaction into 839283a on ethereum:1.0.

@nivida nivida added Feature Request In Progress Currently being worked on labels Apr 6, 2019
@nivida nivida removed the In Progress Currently being worked on label Apr 8, 2019
@nivida nivida merged commit 441c309 into web3:1.0 Apr 8, 2019
@princesinha19 princesinha19 deleted the pending_transaction branch April 8, 2019 13:42
@nivida nivida mentioned this pull request Apr 29, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants