Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Geth node debugging API's (web3-eth-debug). #2678

Merged
merged 17 commits into from
Apr 23, 2019

Conversation

princesinha19
Copy link
Contributor

Description

I implemented all Geth node debugging management API's.
https://github.com/ethereum/go-ethereum/wiki/Management-APIs#list-of-management-apis

Fixes #2637 (Partially)

Type of change

  • New feature

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@princesinha19 princesinha19 changed the title debug-method initial commit Implementation of Geth node debugging API's (web3-eth-debug). Apr 13, 2019
@coveralls
Copy link

coveralls commented Apr 13, 2019

Coverage Status

Coverage increased (+0.08%) to 95.634% when pulling e2be9d0 on princesinha19:debug-methods into 42f9126 on ethereum:1.0.

@nivida nivida added Feature Request In Progress Currently being worked on labels Apr 14, 2019
@nivida nivida requested review from joshstevens19 and removed request for joshstevens19 April 15, 2019 06:39
@nivida nivida removed the In Progress Currently being worked on label Apr 15, 2019
@nivida
Copy link
Contributor

nivida commented Apr 15, 2019

I will write tomorrow the documentation for the Web3 Debug Module and merge your PR after that. Thanks, @princesinha19 for creating all these modules! :)

@princesinha19
Copy link
Contributor Author

okay, @nivida. If you want me to write the documentation then, I can do that.

Copy link
Contributor

@joshstevens19 joshstevens19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top work 👍

@nivida
Copy link
Contributor

nivida commented Apr 17, 2019

@princesinha19 Could you implement the unresolved conversations here? Thanks!:)

@princesinha19
Copy link
Contributor Author

Yes, I will do it today.

@nivida nivida merged commit 7b5728a into web3:1.0 Apr 23, 2019
@princesinha19 princesinha19 deleted the debug-methods branch April 23, 2019 09:30
@nivida nivida mentioned this pull request Apr 29, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all management API methods of Geth
4 participants