Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on contract method proxy when method parameter is null. #2815

Merged
merged 1 commit into from
May 14, 2019

Conversation

Pedro-vk
Copy link

@Pedro-vk Pedro-vk commented May 13, 2019

Description

After upgrade to Web3 beta 55, the method proxy was failing because some parameters were null instead of undefined. This change allows receiving null parameters.

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@Pedro-vk Pedro-vk changed the title Fix error when method parameter is null. Fix error on contract method proxy when method parameter is null. May 13, 2019
@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels May 13, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.947% when pulling b10536a on Pedro-vk:patch-2 into 9528160 on ethereum:1.0.

@coveralls
Copy link

coveralls commented May 13, 2019

Coverage Status

Coverage remained the same at 95.947% when pulling f4a37ca on Pedro-vk:patch-2 into ce93e2d on ethereum:1.0.

@nivida nivida removed the In Progress Currently being worked on label May 14, 2019
@nivida nivida merged commit 9714f30 into web3:1.0 May 14, 2019
@Pedro-vk Pedro-vk deleted the patch-2 branch May 14, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants