Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign correct JSON-RPC response to validate on Web3EthereumProvider.send method #2854

Merged
merged 2 commits into from
May 30, 2019
Merged

Assign correct JSON-RPC response to validate on Web3EthereumProvider.send method #2854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
882aedd
await connection.send method
JunichiSugiura May 29, 2019
b25333c
Merge branch '1.0' into hotfix/web3-eth-provider
nivida May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web3-providers/src/providers/Web3EthereumProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default class Web3EthereumProvider extends AbstractSocketProvider {
* @returns {Promise<Object>}
*/
async send(method, parameters) {
const response = this.connection.send(method, parameters);
const response = await this.connection.send(method, parameters);
const validationResult = JsonRpcResponseValidator.validate(response);

if (validationResult instanceof Error) {
Expand Down