switch repo fork for the websocket package #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
added
1.x
nivida
approved these changes
Jul 29, 2019
The `michaelsbradleyjr/Websocket-Node#polyfill/globalThis` branch uses a more robust approach to resolve a browser's `window` object. It also includes all the latest commits on the upstream's `master` branch, including Node v12.x compatibility and a workaround for the `.git/` subdir npm bug. The `"preinstall"` script in `packages/web3-providers-ws/package.json` is removed because it's not helpful and its use of `rm` causes Windows incompatibility. Closes web3#2971 and web3#2973. `packages/web3-providers-ws/src/index.js` is refactored since the `websocket` package already does native WebSocket detection.
michaelsbradleyjr
force-pushed
the
fix/websocket
branch
from
7a80b6a
to
ca9a01d
Compare
gnidan
approved these changes
Jul 30, 2019
This was referenced Jul 31, 2019
Merged
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
michaelsbradleyjr/Websocket-Node#polyfill/globalThisbranch uses a more robust approach to resolve a browser'swindowobject. It also includes all the latest commits on the upstream'smasterbranch, including Node v12.x compatibility and a workaround for the.git/subdir npm bug.The
"preinstall"script inpackages/web3-providers-ws/package.jsonis removed because it's not helpful and its use ofrmcauses Windows incompatibility. Closes #2971 and #2973.packages/web3-providers-ws/src/index.jsis refactored since thewebsocketpackage already does native WebSocket detection.At some point it will be preferable to install
websocketdirectly from the registry, i.e. by specifying a version number/range inpackages/web3-providers-ws/package.jsonbut this is a way to move forward until a future release of thewebsocketpackage.