Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscription.js Emit 'connected' event with subscription.id #3028

Merged
merged 7 commits into from
Oct 17, 2019
Merged

subscription.js Emit 'connected' event with subscription.id #3028

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ba8bfa
Update subscription.js
lbertenasco Aug 15, 2019
8545173
Merge branch '1.x' into patch-1
nivida Sep 5, 2019
a4fe3f7
Merge branch '1.x' into patch-1
nivida Oct 15, 2019
c72a78c
Updates Changelog and Docs
lbertenasco Oct 17, 2019
48918ba
Merge branch '1.x' into patch-1
lbertenasco Oct 17, 2019
387752a
documentation updated
nivida Oct 17, 2019
ede6d1b
Merge branch '1.x' into patch-1
nivida Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web3-core-subscriptions/src/subscription.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ Subscription.prototype.subscribe = function() {
this.options.requestManager.send(payload, function (err, result) {
if(!err && result) {
_this.id = result;
_this.emit('connected', result);

// call callback on notifications
_this.options.requestManager.addSubscription(_this.id, payload.params[0] , _this.options.type, function(err, result) {
Expand Down