Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Fix regeneratorRuntime error in browser #3062

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

eggplantzzz
Copy link
Contributor

In response to #3058

After researching the error mentioned in the issue above, it seems @babel/preset-env should prevent this error. Currently the package babel-preset-env is being used during bundling which is out of date (deprecated). The error no longer occurs after using the current version of this package (which is now @babel/preset-env), adding a necessary dependency (@babel/core), and updating gulp-babel.

…/preset-env, and add @babel/core to dependencies
@coveralls
Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage remained the same at 83.117% when pulling 8ddd4a9 on trufflesuite:update-build-tools into ce27738 on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Bug Addressing a bug In Progress Currently being worked on labels Sep 10, 2019
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR! Could you update the minified file as well?:)

@eggplantzzz
Copy link
Contributor Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants