The transaction confirmation workflow can now be configured #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nPollingTimeout property added to the Eth, Contract, and Method class
nivida
added
Enhancement
…ransaction fconfirmation workflow configuration properties
…ference in the Eth module fixed
cgewecke
reviewed
Oct 15, 2019
cgewecke
reviewed
Oct 15, 2019
cgewecke
approved these changes
Oct 15, 2019
joshstevens19
approved these changes
Oct 15, 2019
Co-Authored-By: cgewecke <christophergewecke@gmail.com>
Co-Authored-By: cgewecke <christophergewecke@gmail.com>
This was referenced Mar 31, 2020
This was referenced Apr 10, 2020
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* transactionBlockTimeout, transactionConfirmationBlock, and transactionPollingTimeout property added to the Eth, Contract, and Method class * CHANGELOG.md updated * documentation updated * default values added to the documentation for the newely introduced transaction fconfirmation workflow configuration properties * test cases for the new properties added and adding of the Contract reference in the Eth module fixed * missing space added * Update docs/web3-eth.rst Co-Authored-By: cgewecke <christophergewecke@gmail.com> * Update docs/web3-eth-contract.rst Co-Authored-By: cgewecke <christophergewecke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-ports #1581 on the 1.x branch.
ToDo: