-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web3-eth exporting of types from web3-core #3200
Conversation
…ionReceipt, Common, hardfork, and chain export to the web3-eth types. Those interfaces and type definitions will be used from the TS developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing the truffle e2e CI fail on tsc
because it can't find Block
exported from web3-eth.
$ tsc
lib/interface-adapter/types/index.d.ts:1:10 - error TS2305: Module '"../../../node_modules/web3-eth/types"' has no exported member 'Block'.
1 import { Block as EvmBlock } from "web3-eth";
~~~~~
Found 1 error.
It looks like it was removed in this commit.
Is there any way of restoring that as an alias in this PR?
See also #3150
Added the |
Description
This PR will improve the DX for TS developers.
Fixes #3197
Type of change
Checklist:
npm run test
with success and extended the tests if necessary.npm run build
and tested the resulting file fromdist
folder in a browser.